added UIAutomator2 rotation test#516
Merged
TikhomirovSergey merged 2 commits intoappium:masterfrom Nov 18, 2016
saikrishna321:master
Merged
added UIAutomator2 rotation test#516TikhomirovSergey merged 2 commits intoappium:masterfrom saikrishna321:master
TikhomirovSergey merged 2 commits intoappium:masterfrom
saikrishna321:master
Conversation
added automationName
| service.start(); | ||
|
|
||
| if (service == null || !service.isRunning()) { | ||
| throw new RuntimeException("An appium server node is not started!"); |
Member
There was a problem hiding this comment.
@saikrishna321 Should throw AppiumServerHasNotBeenStartedLocallyException.
Member
Member
Contributor
|
@saikrishna321 Yes. Could you improve the issue and then it will be merged |
TikhomirovSergey
approved these changes
Nov 18, 2016
SrinivasanTarget
approved these changes
Nov 18, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Added Rotation tests with UIAutomator2
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply@TikhomirovSergey @SrinivasanTarget review pls